[SPARK-4688] Have a single shared network timeout in Spark by varunsaxena · Pull Request #3562 · apache/spark

varunsaxena · 2014-12-02T22:07:33Z

[SPARK-4688] Have a single shared network timeout in Spark

AmplabJenkins · 2014-12-02T22:12:12Z

Can one of the admins verify this patch?

rxin · 2014-12-02T22:13:20Z

network/common/src/main/java/org/apache/spark/network/util/TransportConf.java

how about

int t = conf.getInt("spark.shuffle.io.connectionTimeout", conf.getInt("spark.network.timeout", 100); return t * 1000;

varunsaxena · 2014-12-02T22:19:47Z

Wanted to know what should be the default spark.network.timeout value ? I have kept it at 100 sec. Should it be different ?

varunsaxena · 2014-12-02T22:46:23Z

Made the changes as per review. Also updated configuration.md

Lewuathe · 2014-12-03T00:16:14Z

core/src/main/scala/org/apache/spark/network/nio/ConnectionManager.scala

Why was default value changed from 60 to 100?

@Lewuathe , that is what I wanted to know. That what should I keep as the default value. Keep a single fixed timeout value for the config spark.network.timeout or change the default based on defaults for earlier configurations which this config intends to replace. As I am pretty new to Spark, I am not aware of what default value will be suitable. Maybe @rxin can confirm.

I think 100 is ok - given the akka timeout was 100.

varunsaxena · 2014-12-04T11:13:42Z

@rxin , any conclusion on what should be the default timeout values used in these different cases ?

rxin · 2014-12-05T00:33:13Z

network/common/src/main/java/org/apache/spark/network/util/TransportConf.java

you need to add a space before 100 here

varunsaxena · 2014-12-05T08:40:34Z

@rxin , I will just summarize what are the configuration defaults I have used. I put a value of 100 in initial pull request with the intention of having a futher discussion on appropriate defaults.

There are 2 approaches possible. We can continue using the same defaults as earlier i.e. spark.network.timeout will have different default values at different places. Or decide a fixed default value. I think latter should be done but an appropriate value has to be decided.

spark.core.connection.ack.wait.timeout - Default value of 60s was used earlier.
spark.shuffle.io.connectionTimeout - Default value of 120s was used earlier.
spark.akka.timeout - Default value of 100s. was used earlier
spark.storage.blockManagerSlaveTimeoutMs - Here default was 3 times value of spark.executor.heartbeatInterval or 45 sec., whichever is higher.

I think based on these cases we can fix a default timeout value of 120 sec. for spark.network.timeout
The only issue i can see is in case 4. But 120 sec. should be a good enough upper cap I think.

[SPARK-4688] Have a single shared network timeout in Spark

varunsaxena · 2014-12-15T20:41:45Z

@rxin , any conclusion on this ?

pwendell · 2014-12-30T22:05:14Z

ping @rxin

rxin · 2014-12-31T18:05:56Z

Jenkins, retest this please.

SparkQA · 2014-12-31T18:07:34Z

Test build #24963 has started for PR 3562 at commit 6e97f72.

This patch merges cleanly.

SparkQA · 2014-12-31T19:33:23Z

Test build #24963 has finished for PR 3562 at commit 6e97f72.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

AmplabJenkins · 2014-12-31T19:33:26Z

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/24963/
Test PASSed.

rxin · 2015-01-05T18:32:41Z

Thanks. I'm merging this in master.

varunsaxena · 2015-01-05T19:23:06Z

Thanks for the review and commit.

SPARK-4688

594226c

rxin reviewed Dec 2, 2014
View reviewed changes

SPARK-4688

a75f014

Lewuathe reviewed Dec 3, 2014
View reviewed changes

varunsaxena added 2 commits December 3, 2014 13:27

SPARK-4688

9562b15

SCALA-4688

d6f8c29

rxin reviewed Dec 5, 2014
View reviewed changes

network/common/src/main/java/org/apache/spark/network/util/TransportConf.java Outdated

Copy link

Contributor

rxin Dec 5, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you need to add a space before 100 here

SPARK-4688

cd783a2

[SPARK-4688] Single shared network timeout

6e97f72

[SPARK-4688] Have a single shared network timeout in Spark

asfgit closed this in d3f07fd Jan 5, 2015

Conversation

varunsaxena commented Dec 2, 2014

Uh oh!

AmplabJenkins commented Dec 2, 2014

Uh oh!

rxin Dec 2, 2014

Choose a reason for hiding this comment

Uh oh!

varunsaxena commented Dec 2, 2014

Uh oh!

varunsaxena commented Dec 2, 2014

Uh oh!

Lewuathe Dec 3, 2014

Choose a reason for hiding this comment

Uh oh!

varunsaxena Dec 3, 2014

Choose a reason for hiding this comment

Uh oh!

rxin Dec 5, 2014

Choose a reason for hiding this comment

Uh oh!

varunsaxena commented Dec 4, 2014

Uh oh!

rxin Dec 5, 2014

Choose a reason for hiding this comment

Uh oh!

varunsaxena commented Dec 5, 2014

Uh oh!

varunsaxena commented Dec 15, 2014

Uh oh!

pwendell commented Dec 30, 2014

Uh oh!

rxin commented Dec 31, 2014

Uh oh!

SparkQA commented Dec 31, 2014

Uh oh!

SparkQA commented Dec 31, 2014

Uh oh!

AmplabJenkins commented Dec 31, 2014

Uh oh!

rxin commented Jan 5, 2015

Uh oh!

varunsaxena commented Jan 5, 2015

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants